magento/magento2#39873: addProductsToCart mutation doesn't work as expect with a given parent_sku #39950

KrasnoshchokBohdan · 2025-05-28T21:02:31Z

Description (*)

First part -
In this issue, the author mentioned that responce from

this mutation

mutation {
  addProductsToCart(
    cartId: "LclKxxxxxxxxxxxxxxW"
    cartItems: [
      {
        quantity: 1
        parent_sku: "WSH12"
        sku: "WSH12-28-Green"
      }
    ]
  ) {
    cart {
      itemsV2 {
        items {
          id
          product {
            name
            sku
          }
          quantity
        }
        total_count
        page_info {
          page_size
          current_page
          total_pages
        }
      }
    }
    user_errors {
      code
      message
    }
  }
}

doesn't match

this expected result

{
  "data": {
    "addProductsToCart": {
      "cart": {
        "itemsV2": {
          "items": [
            {
              "id": "24",
              "product": {
                "name": "Erika Running Short",
                "sku": "WSH12"
              },
              "quantity": 1
            },
            {
              "id": "26",
              "product": {
                "name": "Erika Running Short-28-Green",
                "sku": "WSH12-28-Green"
              },
              "quantity": 1
            }
          ],
          "total_count": 2,
          "page_info": {
            "page_size": 20,
            "current_page": 1,
            "total_pages": 1
          }
        }
      },
      "user_errors": []
    }
  }
}

instead, we get

this actual result

{
  "data": {
    "addProductsToCart": {
      "cart": {
        "itemsV2": {
          "items": [
            {
              "id": "18",
              "product": {
                "name": "Erika Running Short-28-Green",
                "sku": "WSH12-28-Green"
              },
              "quantity": 1
            }
          ],
          "total_count": 1,
          "page_info": {
            "page_size": 20,
            "current_page": 1,
            "total_pages": 1
          }
        }
      },
      "user_errors": []
    }
  }
}

let's add a configurable product to the cart from frontend

in the "quote_item" table we have 2 items

let's try this query

and in the responce, we see only the configurable product
the reason for this is
\Magento\QuoteGraphQl\Model\Resolver\CartItemsPaginated::resolve
\Magento\Quote\Model\Quote::getAllVisibleItems

(item with sku "test simple" has parent_item_id)

so maybe it's better to change the responce example on this page instead of changing the code in \Magento\Quote\Model\Quote::getAllVisibleItems

Second part -
let's add a configurable product to the cart using the "addProductsToCart" mutation

in the responce we see only "test simple", and in "quote_item" table we have only one item

so I created ConfigurableProductPrecursor to add a configurable product to the cart along with a simple product.

Related Pull Requests

Fixed Issues (if relevant)

Fixes magento/magento2#39873

Manual testing scenarios (*)

1.create an empty cart the official doc
2.add a product by specifying parent_sku following the official doc

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

… a given parent_sku - adding new ConfigurableProductPrecursor

m2-assistant · 2025-05-28T21:02:34Z

Hi @KrasnoshchokBohdan. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

… a given parent_sku - modifying ConfigurableProductPrecursor

KrasnoshchokBohdan · 2025-06-03T14:22:54Z

@magento run all tests

… a given parent_sku - Introduced comprehensive unit tests for ConfigurableProductPrecursor, covering scenarios like valid configurations, non-configurable parents, missing attributes, and missing products. Minor code adjustments were also made for improved readability and array merging in the process method.

KrasnoshchokBohdan · 2025-06-12T08:59:19Z

@magento run all tests

KrasnoshchokBohdan · 2025-06-23T06:44:45Z

@magento run all tests

engcom-Hotel · 2025-07-18T06:15:44Z

@magento run all tests

… a given parent_sku Refactor constructor and update error message formatting Replaced manual property assignment in the constructor with a `readonly` property for `ProductRepositoryInterface` to simplify initialization. Improved code readability by adjusting the formatting of the error message array.

KrasnoshchokBohdan · 2025-07-19T12:41:05Z

@engcom-Hotel Hi! I stuck with WebAPI tests, in report I see /var/www/html/dev/tests/api-functional/phpunit.xml
but there is no such file in the magento2 repository

and all my attempts with dev/tests/api-functional/phpunit_graphql.xml leads to errors
https://developer.adobe.com/commerce/webapi/graphql/develop/functional-testing/

KrasnoshchokBohdan · 2025-07-19T12:41:23Z

@magento run all tests

… a given parent_sku Refactor unused parameter in ConfigurableProductPrecursor. Renamed the parameter to align with coding standards and added a suppression for PHPMD warnings about unused parameters. This change improves code clarity and adheres to best practices.

KrasnoshchokBohdan · 2025-07-19T17:37:22Z

@magento run all tests

engcom-Hotel · 2025-07-21T09:06:37Z

@engcom-Hotel Hi! I stuck with WebAPI tests, in report I see /var/www/html/dev/tests/api-functional/phpunit.xml
but there is no such file in the magento2 repository

Hello @KrasnoshchokBohdan,

By default, the file is named with the .dist suffix and is located at dev/tests/api-functional/. To proceed, please rename it to phpunit.xml in the same directory. For further details on running the tests, you may refer to the following documentation:

https://developer.adobe.com/commerce/webapi/get-started/web-api-functional-testing/#running-the-tests

I hope this addresses your question.

Thanks

KrasnoshchokBohdan · 2025-07-21T10:44:29Z

Hi! @engcom-Hotel
https://github.com/magento/magento2/tree/2.4-develop/dev/tests/api-functional

should I rename phpunit_graphql.xml.dist to phpunit.xml? Sorry, maybe I misunderstood something, but I don't see phpunit.xml.dist in the folder

engcom-Hotel · 2025-07-22T08:52:16Z

Hello @KrasnoshchokBohdan,

In order to run the graphql functional test on your local machine, please go through with the below documentation:

https://developer.adobe.com/commerce/webapi/graphql/develop/functional-testing/#run-functional-tests

Thanks

engcom-Dash · 2025-07-29T10:59:37Z

@magento run all tests

engcom-Dash · 2025-07-30T10:42:21Z

Hi @KrasnoshchokBohdan

Thank you for your work on this PR. While reviewing the pull request and the associated issue, I noticed that the issue is no longer reproducible. According to the documentation, the addProductsToCart mutation now returns the child product in the response.

Please find the link: https://developer.adobe.com/commerce/webapi/graphql/schema/cart/mutations/add-products/#specify-a-parent-and-a-child-sku

On 2.4-develop, as per the documentation we can see the correct behaviour.

Created an empty cart using graphQL mutation
Added configurable Product using "addProductsToCart" mutation

I understand that your PR aims to address the inconsistent behavior observed when adding a configurable product via the storefront versus through GraphQL.

However, I noticed that the changes introduced in the PR result in only parent SKUs being returned in both scenarios—storefront and GraphQL. This behavior is actually opposite to what’s documented Here. According to the documentation on the 2.4-develop branch, the addProductsToCart mutation should return the child product in the response.

Responses returned on the PR branch

Added Product to Cart Via GraphQL :

Added Product to cart via storefront:

Could you please update the PR to align with the documented behavior? Additionally, please create a new issue describing the observed behaviour and update the PR description to reference that issue.

Looking forward to your response.

Thanks!

KrasnoshchokBohdan · 2025-07-30T11:12:26Z

@engcom-Dash Hi!
Please check AdobeDocs/commerce-webapi#438

I made this pull request in order to either update it after approval of this pull request or to update the example response according to the current result.

I hope we can handle this pull request and I will create a new one in the documentation.

Usually pull requests for documentation can take a long time to be considered so I couldn't assume it would be merged earlier than this one, sorry

engcom-Dash · 2025-07-31T09:39:14Z

Hello @KrasnoshchokBohdan,

We have sent an Email to the Product Owner on the clarification of the expected behaviour for both mutation & query. Till then we are moving this PR on Hold.

Thanks!

tkacheva · 2025-08-14T15:20:43Z

Hi @KrasnoshchokBohdan,
thanks for submitting PR! @engcom-Dash is right - expected behavior of the addProductsToCart mutation is to return child products of the parent configurable that are added to cart based on the selected configurable options.
on the storefront this function \Magento\Quote\Model\Quote::getAllVisibleItems returns visible products, in this case a parent configurable as child of a configurable is not visible individually.

engcom-Dash · 2025-08-26T13:11:49Z

Hi @KrasnoshchokBohdan,

Did you get a chance to look at a comment #39950 (comment) ?

Thanks!

engcom-Dash · 2025-09-08T13:00:07Z

Hi @KrasnoshchokBohdan,
Just following up to check if you had a chance to review the last comment #39950 (comment) ?

KrasnoshchokBohdan · 2025-09-27T12:17:04Z

HI! If I understand everything right from the comment, there is no need in this pull request and this pr to devdocks is enough.

engcom-Dash · 2025-10-08T11:41:02Z

Hello @KrasnoshchokBohdan,

Yes, as per the Product Owner’s feedback from Olena comment the expected behavior for both the mutation and query is to display the child products. This is consistent with what we already observe in the 2.4-develop branch.

I have verified this in the 2.4-develop environment

Additionally, the behavior aligns with the documentation reference mentioned in the Add configurable product to cart mutation.

So, as the expected behavior matches the current implementation in 2.4-develop and aligns with the Product Owner’s confirmation, we are good to close this PR.

If you have any additional feedback or suggestions regarding this PR, please feel free to reopen it or create a separate PR.

Thank you for your contribution!

magento#39873: addProductsToCart mutation doesn't work as expect with…

de48c3b

… a given parent_sku - adding new ConfigurableProductPrecursor

KrasnoshchokBohdan marked this pull request as draft May 28, 2025 21:02

sidolov added Partner: Perspective partners-contribution Pull Request is created by Magento Partner labels May 29, 2025

KrasnoshchokBohdan and others added 3 commits June 3, 2025 17:19

magento#39873: addProductsToCart mutation doesn't work as expect with…

287b14e

… a given parent_sku - modifying ConfigurableProductPrecursor

Update AddProductsToCart.php

385a088

Merge branch '2.4-develop' into fix-for-issue-39873

825c000

KrasnoshchokBohdan marked this pull request as ready for review June 4, 2025 04:57

KrasnoshchokBohdan mentioned this pull request Jun 4, 2025

"Add a configurable product to a cart" changes for response AdobeDocs/commerce-webapi#438

Merged

engcom-Bravo added the Priority: P3 May be fixed according to the position in the backlog. label Jun 4, 2025

ct-prd-projects-boards-automation bot added this to Pull Requests Dashboard Jun 4, 2025

github-project-automation bot moved this to Pending Review in Pull Requests Dashboard Jun 4, 2025

ct-prd-projects-boards-automation bot added the Progress: pending review label Jun 4, 2025

KrasnoshchokBohdan and others added 2 commits June 12, 2025 11:58

Merge branch '2.4-develop' into fix-for-issue-39873

b77f44a

Merge branch '2.4-develop' into fix-for-issue-39873

e8c0d17

engcom-Charlie added the Project: Community Picked PRs upvoted by the community label Jul 14, 2025

ct-prd-projects-boards-automation bot added this to Community Dashboard Jul 14, 2025

ct-prd-projects-boards-automation bot moved this to Pending Review in Community Dashboard Jul 14, 2025

ct-prd-projects-boards-automation bot removed this from Pull Requests Dashboard Jul 14, 2025

engcom-Hotel self-requested a review July 18, 2025 06:15

ct-prd-projects-boards-automation bot added the Progress: review label Jul 18, 2025

Merge branch '2.4-develop' into fix-for-issue-39873

99219b1

ct-prd-projects-boards-automation bot removed the Progress: pending review label Jul 18, 2025

ct-prd-projects-boards-automation bot moved this from Pending Review to Review in Progress in Community Dashboard Jul 18, 2025

ct-prd-projects-boards-automation bot removed the Progress: review label Jul 18, 2025

engcom-Dash self-assigned this Jul 24, 2025

Merge branch '2.4-develop' into fix-for-issue-39873

71bc94b

engcom-Dash moved this from Changes Requested to On Hold in Community Dashboard Jul 31, 2025

ct-prd-projects-boards-automation bot added Progress: on hold Progress: review and removed Progress: needs update labels Jul 31, 2025

ct-prd-projects-boards-automation bot moved this from On Hold to Review in Progress in Community Dashboard Jul 31, 2025

engcom-Dash moved this from Review in Progress to On Hold in Community Dashboard Jul 31, 2025

ct-prd-projects-boards-automation bot removed the Progress: review label Jul 31, 2025

engcom-Dash closed this Oct 8, 2025

ct-prd-projects-boards-automation bot removed this from Community Dashboard Oct 8, 2025

engcom-Bravo mentioned this pull request Oct 8, 2025

[GraphQL] - addProductsToCart mutation doesn't work as expect with a given parent_sku #39873

Closed

5 tasks

magento/magento2#39873: addProductsToCart mutation doesn't work as expect with a given parent_sku #39950

magento/magento2#39873: addProductsToCart mutation doesn't work as expect with a given parent_sku #39950

Uh oh!

Conversation

KrasnoshchokBohdan commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented May 28, 2025

Uh oh!

KrasnoshchokBohdan commented Jun 3, 2025

Uh oh!

KrasnoshchokBohdan commented Jun 12, 2025

Uh oh!

KrasnoshchokBohdan commented Jun 23, 2025

Uh oh!

engcom-Hotel commented Jul 18, 2025

Uh oh!

KrasnoshchokBohdan commented Jul 19, 2025

Uh oh!

KrasnoshchokBohdan commented Jul 19, 2025

Uh oh!

KrasnoshchokBohdan commented Jul 19, 2025

Uh oh!

engcom-Hotel commented Jul 21, 2025

Uh oh!

KrasnoshchokBohdan commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

engcom-Hotel commented Jul 22, 2025

Uh oh!

engcom-Dash commented Jul 29, 2025

Uh oh!

engcom-Dash commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KrasnoshchokBohdan commented Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

engcom-Dash commented Jul 31, 2025

Uh oh!

tkacheva commented Aug 14, 2025

Uh oh!

engcom-Dash commented Aug 26, 2025

Uh oh!

engcom-Dash commented Sep 8, 2025

Uh oh!

KrasnoshchokBohdan commented Sep 27, 2025

Uh oh!

engcom-Dash commented Oct 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

KrasnoshchokBohdan commented May 28, 2025 •

edited

Loading

KrasnoshchokBohdan commented Jul 21, 2025 •

edited

Loading

engcom-Dash commented Jul 30, 2025 •

edited

Loading

KrasnoshchokBohdan commented Jul 30, 2025 •

edited

Loading